Skip to content

fix: pico4-monado fits the colour room view's lens model only over the angles it shows, so the room no longer wobbles toward the edges - #21

Merged
Xenolphthalein merged 1 commit into
mainfrom
fix/roomview-fit-angle
Nov 17, 2026
Merged

Xenolphthalein merged 1 commit into
mainfrom
fix/roomview-fit-angle

Conversation

@Xenolphthalein

Copy link
Copy Markdown
Contributor

The colour room view wobbled slightly toward the edges of the view when the head moved, while the middle stayed stable (overpressure/phoenix#50).

The RGB camera's lens model (PICO's fisheye62, with tangential terms) is fitted to the KB4 model the compositor takes. The fit used rays out to the image's corners, 80–90° off axis, which the headset never shows and where the fit is up to 12 px off; they pulled it off inside the view. Measured on a headset's own calibration, in pixels of the 1164×874 image the compositor gets, the error swung between 0.3 and 1.7 px from 20° to 55° off axis (worst 2.0 px, 0.26°, at 55°), so points wobbled as they crossed the view.

  • pico4_tcam_fit_kb4_within() fits over the rays up to a given angle; the colour room view fits up to 70° (PICO4_TCAM_ROOMVIEW_DEG, the view's edge is at about 55–60°). The error now grows smoothly from under 0.1 px in the middle to about 1 px (worst 1.5 px) at 55–60°; what is left is the tangential part, which KB4 cannot express.
  • The room view logs the fit's error at its start ("lens fit up to 70 degrees: rms …, max …").
  • The head tracker's fits and the grey pair's stay as they were.
  • A C test checks that the 70° fit is closer than the full one inside 60° on the fixture's model. pkgrel 18.

Worn A/B on the headset, with the built driver_monado.so bind-mounted against release 17: the new fit is clearly steadier at the edges. Refs overpressure/phoenix#50.

…e angles it shows, so the room no longer wobbles toward the edges

The RGB camera's fisheye62 model was fitted to KB4 over rays out to the image's corners (80-90 degrees off
axis, up to 12 px off), which the headset never shows; they pulled the fit off inside the view, where its error
swung between 0.3 and 1.7 px (worst 2.0 px at 55 degrees) and the room wobbled as points crossed it. Fitted up
to 70 degrees it grows smoothly to about 1 px at the view's edge. The room view logs the fit's error at its
start. The head tracker's fits stay as they were.
@Xenolphthalein
Xenolphthalein enabled auto-merge (rebase) November 17, 2026 09:14
@Xenolphthalein
Xenolphthalein merged commit df0137e into main Nov 17, 2026
22 checks passed
@Xenolphthalein
Xenolphthalein deleted the fix/roomview-fit-angle branch November 17, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant